Age | Commit message (Collapse) | Author |
|
When setting virtual-root from cgitrc, care is taken to avoid trailing
slashes. But when no virtual-root setting is specified, SCRIPT_FILE
from the web server is used without similar checks. This patch fixes the
inconsistency, which could lead to double-slashes in generated links.
Noticed-by: Wouter Van Hemel <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
When a query ends in say %gg, (or any invalid hex) e.g.,
http://git.gnome.org/browse/gdlmm/commit/?id=%gg
convert_query_hexchar calls memmove(txt, txt+3, 0), and then returns
txt-1, so the loop in http_parse_querystring never terminates. The
solution is to make the memmove also copy the trailing NUL.
* html.c (convert_query_hexchar): Fix off-by-one error.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
warning: format ‘%ld’ expects type ‘long int’, but argument 2 has type
‘size_t’
Signed-off-by: Bernhard Reutner-Fischer <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
OpenBSD tar(1) defaults to read from "/dev/rst0" when not specifying an
filename and thus fails to extract the Git sourcecode when not passing
stdin as input file descriptor explicitly.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
repo.readme is transformed to an absolute path when read from the config,
so add_repo needs to add "README.html" with the repository path too.
Signed-off-by: Dean Scarff <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
This fixes http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2010-2542.
Noticed-by: Silvio Cesare <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
The format uses a 'Z' suffix, which indicates no TZ offset.
Thus we should not respect the local-time config setting here.
Signed-off-by: Aaron Griffin <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Since cgit linked with git-1.6.0 all zip archives has been uncompressed.
This patch fixes the issue by specifying Z_DEFAULT_COMPRESSION.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
The source and destination strings in strcpy() may not overlap.
Instead, use memmove(), which allows overlap. This fixes test t0104,
where 'url=foo%2bbar/tree' was being parsed improperly.
Signed-off-by: Mark Lodato <[email protected]>
|
|
Signed-off-by: Mark Lodato <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
When a ref refers to something other then a commit or tag object, cgit
could segfault when trying to display the tag info.
Noticed-by: Eugene Sajine <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
When a commit has a specific encoding, this encoding also applies to
the author and committer name and email.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
PATH_INFO="/$REPONAME/commit/?id=1" QUERY_STRING="id=1" ./cgit.cgi
triggers segfault when the repository is empty and therefore
ctx.qry.head is unset
Signed-off-by: Florian Pritz <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Noticed-by: Andreas Schwab <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
|
|
Signed-off-by: Geoff Johnstone <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Loui Chang <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
This prevents FIXMEs from appearing.
Signed-off-by: Loui Chang <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
|
|
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
|
|
When a path to a directory was specified for the 'plain'
view, each blob in the directory used to be returned to
the client. This patch fixes the issue by matching the
path of each blob against the requested path.
Noticed-by: Lars Stoltenow <[email protected]>
Signed-off-by: Lars Hjemli <[email protected]>
|
|
The repo-specific 'snapshots' option is bitwise AND'ed with the global
'snapshots' option during parsing, and since the global cgitrc hasn't
been parsed when --scan-path is processed the global 'snapshots' will
always be 0 (i.e. no repo-specific 'snapshots' setting will have any
effect).
This patch fixes the issue by setting the global 'snapshots' mask to
0xFF (hence relying on later parsing of the generated cgitrc repolist
to do the right thing).
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Since repo.desc might have been populated by reading the 'description'
file in GIT_DIR, it may contain newlines. And by printing the literal
value, we may then generate an invalid cgitrc include-file.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Note: print_repo() still ignores repo.max-stats and repo.snapshots,
which both requires additional work since these settings are represented
internally as an enum and a bitmap.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
This option must be enabled if repo-specific cgitrc files should be
allowed to override any of the 'filter' options.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
Signed-off-by: Lars Hjemli <[email protected]>
|
|
When recursively scanning a directory tree looking for git repositories,
cgit will now parse cgitrc files found within such repositories.
The repo-specific config files can include any repo-specific options
except 'repo.url' and 'repo.path'. Also, in such config files the 'repo.'
prefix can not be used, i.e. the valid options then becomes:
* name
* clone-url
* desc
* ower
* defbranch
* snapshots
* enable-log-filecount
* enable-log-linecount
* max-stats
* module-link
* section
* about-filter
* commit-filter
* source-filter
* readme
Signed-off-by: Lars Hjemli <[email protected]>
|
|
The new function repo_config() is used to handle all 'simple' repo
options, for the following reasons:
* code readability
* parser performance
* upcoming support for repo-local cgitrc files during scanning
Signed-off-by: Lars Hjemli <[email protected]>
|
|
When no sorting is requested by the client, cgit will now sort by
section name followed by repo name. This allows repos to be registered/
discovered independently of their display order.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
This option can be used to specify the section name for the current
repository.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
The 'repo.' prefix should be reserved for repo-specific options, but
the option 'repo.group' must still be honored to stay backwards
compatible.
Signed-off-by: Lars Hjemli <[email protected]>
|
|
This is an alias for --scan-tree (which might be deprecated in the
future).
Signed-off-by: Lars Hjemli <[email protected]>
|